[TPDE][LLVM] Add get_mapped_range method to JITMapper #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can I ask what the motivation of this is devoid of any information where the code is mapped? |
Contributor
Author
|
@T0b1-iOS As you probably know, our use case is an in-memory database. We need to know the size of the allocation to be able to make decisions regarding caching and OOM prevention. |
Member
|
Yeah, providing a range of the mapped region is probably a better choice. That would be good |
This allows to obtain the address range of the allocated memor slab by the underlying ElfMapper. The allocation size is the ptrdiff between first and second of the returned pair.
marcauberer
force-pushed
the
tpde/get-mapped-size
branch
from
2965374 to
2a0b008
Compare
marcauberer
changed the title
Contributor
Author
|
@T0b1-iOS Done. Now a pair of start and end address of the allocation is returned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to obtain the address range of the allocated memor slab by
the underlying ElfMapper. The allocation size is the ptrdiff between
first and second of the returned pair.
Additional change:
Mark
get_sym_addras const, since it only performs a map lookup.